Update intro to PTAXSIM vignette#87
Merged
kyrasturgill merged 10 commits into2024-data-updatefrom Apr 28, 2026
Merged
Conversation
jeancochrane
approved these changes
Apr 23, 2026
Member
jeancochrane
left a comment
jeancochrane
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround here! No serious concerns, just a few tiny suggestions below.
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Member
Author
|
Thanks so much for your careful review and catching my sloppy typos and edits. Lmk if you think this is now good to merge. |
kyrasturgill
deleted the
kyrasturgill/intro-to-ptaxsim-vignette-2024-update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most substantial edit here is adding in documentation for the
pin_tif_dtand adding some explainers on that. While I was in here, I figured may as well update demo code snippets to use 2024 so that they are more current/relevant.